Here is how to verify your guess.
For any estimator $f(Y)$,
\begin{align}
\mathbb{E}(f(Y) - S)^2
&= \mathbb{E}(f(Y) - \mathbb{E}[S \mid Y] + \mathbb{E}[S \mid Y] - S)^2\\
&= \mathbb{E}(f(Y) - \mathbb{E}[S \mid Y])^2
+ 2 \mathbb{E}[(f(Y) - \mathbb{E}[S \mid Y])(\mathbb{E}[S \mid Y] - S)]
+ \mathbb{E}(\mathbb{E}[S \mid Y]-S)^2\\
&= \mathbb{E}(f(Y) - \mathbb{E}[S \mid Y])^2
+ 0
+ \mathbb{E}(\mathbb{E}[S \mid Y]-S)^2\\
&\ge \mathbb{E}(\mathbb{E}[S \mid Y]-S)^2.
\end{align}
(See below for why the cross term is zero.)
Choosing $f(Y) = \mathbb{E}[S \mid Y]$ makes the last inequality tight so it minimizes $\mathbb{E}(f(Y) - S)^2$ over all estimators $f(Y)$.
Note that we can rewrite this estimator as $\mathbb{E}[S \mid Y] = Y - \mathbb{E}[W \mid Y]$.
This answer holds for both Q1 and Q2. However, I have not leveraged independence nor the assumption that $S$ and $W$ have the same pdf... perhaps they want you to explicitly write out what $\mathbb{E}[S \mid Y]$ looks like under those conditions.
To see that the cross term vanishes, note the tower property yields
\begin{align}
\mathbb{E}[(f(Y) - \mathbb{E}[S \mid Y])(\mathbb{E}[S \mid Y] - S)]
&= \mathbb{E}\big[\mathbb{E}\big[(f(Y) - \mathbb{E}[S \mid Y])(\mathbb{E}[S \mid Y] - S) \mid Y\big]\big]\\
&= \mathbb{E}\big[(f(Y) - \mathbb{E}[S \mid Y]) (\mathbb{E}[S \mid Y] - \mathbb{E}[S \mid Y])\big]\\
&= 0.
\end{align}